I am upgrading from a eos xs rebel. Would the t3i be a good choice.

[ebiggs1]

Sure!   But the question is deeper than that. What do you expect? Or, what do you want to accomplish?

[TCampbell]

It's always nice to know what type of shooting you want to do before answering the question because some cameras are paritcularly good at certain types of things -- but not so good for other uses.

If we knew the type of shooting you plan to do, we could do a better job of describing what attributes will be important and which camera bodies provide those attributes.